feat: add live-select for shapes autocompletion#1035
Conversation
mix.exs
Outdated
| {:phoenix_live_react, "~> 0.4"}, | ||
| {:phoenix_html, "~> 4.0"}, | ||
| {:phoenix_html_helpers, "~> 1.0"}, | ||
| {:phoenix_live_react, path: "/Users/mharty/git/phoenix_live_react"}, |
There was a problem hiding this comment.
There was a problem hiding this comment.
mix.exs
Outdated
| {:postgrex, ">= 0.0.0"}, | ||
| # If react_phoenix changes, check assets/src/ReactPhoenix.js, too | ||
| {:react_phoenix, "1.3.1"}, | ||
| {:react_phoenix, path: "/Users/mharty/git/react-phoenix"}, |
There was a problem hiding this comment.
There was a problem hiding this comment.
| {:phoenix_live_reload, "~> 1.5", only: :dev}, | ||
| {:phoenix_html, "~> 3.0"}, | ||
| {:phoenix_live_react, "~> 0.4"}, | ||
| {:phoenix_html, "~> 4.0"}, |
There was a problem hiding this comment.
phoenix_live_react and react-phoenix don't have compatibility yet with this version of phoenix_html. See comments with branches of my forks.
There was a problem hiding this comment.
I didn't get any attention on the PRs to the open source projects, so I created my own fork for phoenix_live_react and updated the mbta for react-phoenix.
It didn't make sense to try to combine the two package because the integration is different. Liveview's JS has it's own setup with hooks and event functions.
There was a problem hiding this comment.
A difference between the two packages is the behavior on DOMContentLoaded.
for phoenix_live_react (https://github.com/fidr/phoenix_live_react/blob/5166af8209192cf421eccaa66cdaaeba2b9309ce/README.md?plain=1#L46-L51):
// Optionally render the React components on page load as
// well to speed up the initial time to render.
// The pushEvent, pushEventTo and handleEvent props will not be passed here.
document.addEventListener("DOMContentLoaded", e => {
initLiveReact()
})
vs. non-optional (part of source code, not app.js) in react-phoenix:
https://github.com/mbta/react-phoenix/blob/23728aae60cad3f478c06d1047f4b1a65d5c2b5a/src/react_phoenix.js#L18-L20
If it's important to us to reduce this to one elixir package, we could create a follow-up ticket.
There was a problem hiding this comment.
it looks like this was merged/released in the main repo https://github.com/fidr/phoenix_live_react/releases/tag/v0.6.0
There was a problem hiding this comment.
I updated phoenix_live_react to point back to the main repo, thank you!
meagharty
force-pushed
the
meag/try-live-select
branch
3 times, most recently
from
432cb07 to
513ca9c
Compare
meagharty
changed the title
meagharty
changed the title
meagharty
requested review from
a team and
bfauble
and removed request for
a team
meagharty
force-pushed
the
meag/try-live-select
branch
2 times, most recently
from
a0ac4de to
f3f1dcc
Compare
… of react-phoenix
meagharty
force-pushed
the
meag/try-live-select
branch
from
0f00985 to
fe18f01
Compare
2 participants
Summary of changes
Asana Ticket: 🏹 Implement "Create/Edit Shuttle Route Definition": Autocomplete for shapes
Reviewer Checklist