Skip to content

Deviate should allow to add extension sub-statements#216

Open
paulo-g wants to merge 2 commits intombj4668:masterfrom
paulo-g:master
Open

Deviate should allow to add extension sub-statements#216
paulo-g wants to merge 2 commits intombj4668:masterfrom
paulo-g:master

Conversation

@paulo-g
Copy link
Copy Markdown

@paulo-g paulo-g commented Apr 8, 2016

Fix for #214

paulo-g added 2 commits April 8, 2016 11:41
Support extensions in add deviations.
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 64.601% when pulling 9211a6c on paulo-g:master into 38ee1c3 on mbj4668:master.

@mbj4668
Copy link
Copy Markdown
Owner

mbj4668 commented Apr 27, 2016

Hi,
There is already support for handling this on a per-extension basis. The idea is that if you have a module with extensions (e.g. ietf-yang-smiv2), you can write a plugin that registers the grammar for the extensions (e.g. smi.py). This plugin can also register keywords that can be deviated, by using the function add_deviation_element() in statements.py.

@mbj4668 mbj4668 closed this May 9, 2016
@paulo-g
Copy link
Copy Markdown
Author

paulo-g commented May 10, 2016

@mbj4668 , understood, but that will limit the possibility to share the model without a companion plugin.

My interpretation from the RFC text was that, by omission, an extension would support to be deviated, and only when providing a dedicated plugin could this change. Which is the opposite interpretation that was implemented.

In any case I agree with the decision.
Thanks!

@mbj4668 mbj4668 reopened this Nov 2, 2016
@mbj4668 mbj4668 closed this in 5ae3d9d Nov 2, 2016
@mbj4668
Copy link
Copy Markdown
Owner

mbj4668 commented Nov 2, 2016

Incorrect reference, should have been 126.

@mbj4668 mbj4668 reopened this Nov 2, 2016
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 2, 2016

Coverage Status

Coverage decreased (-33.8%) to 30.812% when pulling 9211a6c on paulo-g:master into 38ee1c3 on mbj4668:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 2, 2016

Coverage Status

Coverage decreased (-33.8%) to 30.752% when pulling 9211a6c on paulo-g:master into 38ee1c3 on mbj4668:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants