Skip to content

Upgrade gradle/actions to v6 with basic caching#23

Merged
oschwald merged 2 commits into
mainfrom
greg/eng-4638
Apr 7, 2026
Merged

Upgrade gradle/actions to v6 with basic caching#23
oschwald merged 2 commits into
mainfrom
greg/eng-4638

Conversation

@oschwald
Copy link
Copy Markdown
Member

@oschwald oschwald commented Apr 6, 2026

Summary

  • Upgrade gradle/actions/setup-gradle from v5.0.2 to v6.1.0 across all workflows
  • Use the MIT-licensed basic caching provider (a thin wrapper over actions/cache) instead of the default enhanced caching, which is proprietary and subject to the Gradle Technologies Terms of Use
  • Add yamllint and prettier to mise.toml so all precious pre-commit dependencies are available via mise install

Resolves ENG-4638

Test plan

  • CI workflow passes with the new action version and basic caching
  • CodeQL workflow passes (caching remains disabled)
  • API compatibility check workflow passes
  • mise install && precious lint -a succeeds in a clean checkout

🤖 Generated with Claude Code

oschwald and others added 2 commits April 6, 2026 21:51
Use the MIT-licensed basic caching provider (a thin wrapper over
actions/cache) instead of the default enhanced caching, which is
proprietary and subject to separate terms of use.

Resolves ENG-4638

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
These are used by precious for pre-commit linting. Previously prettier
was invoked via npx, requiring Node.js to be installed separately.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .precious.toml configuration to call prettier directly and simplifies the stderr ignore list. It also adds yamllint and prettier to the mise.toml configuration. A review comment points out that these tools may not be available in the default mise registry and suggests using explicit provider prefixes like pip: and npm: to ensure successful installation.

Comment thread mise.toml
Comment on lines +8 to +10
yamllint = "latest"
# prettier is used by precious for Markdown formatting
prettier = "latest"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The tools yamllint and prettier are not included in the default mise registry. To ensure they are correctly installed via mise install as intended by the PR description, you should use explicit provider prefixes. Using pip: for yamllint and npm: for prettier is the standard approach. Note that these providers require the corresponding runtimes (Python and Node.js) to be available on the system or managed via mise.

"pip:yamllint" = "latest"
# prettier is used by precious for Markdown formatting
"npm:prettier" = "latest"

Copy link
Copy Markdown

@blakeyjason blakeyjason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change looks good.

@oschwald oschwald merged commit f288a82 into main Apr 7, 2026
7 of 9 checks passed
@oschwald oschwald deleted the greg/eng-4638 branch April 7, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants