Skip to content

hexagon: add Q4_1 support to MUL_MAT#55

Open
max-krasnyansky wants to merge 1 commit intomasterfrom
jules-120578630328963272-959ca86c
Open

hexagon: add Q4_1 support to MUL_MAT#55
max-krasnyansky wants to merge 1 commit intomasterfrom
jules-120578630328963272-959ca86c

Conversation

@max-krasnyansky
Copy link
Copy Markdown
Owner

Add support for Q4_1 data type for MUL_MAT ops in the Hexagon backend.

  • Add support for repacking Q4_1 into Q4_1x4x2.
  • Add support for vec_dot_1x1,2x1,2x2 kernels.
  • Update matmul_2d code to handle src0 in Q4_1x4x2.
  • Update supported MUL_MAT types.
  • Fix dot product kernels for Q4_1x4x2 format.
  • Add HMX dequantization logic for Q4_1.

PR created automatically by Jules for task 120578630328963272 started by @max-krasnyansky

Co-authored-by: max-krasnyansky <1380796+max-krasnyansky@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant