chore: upgrade hidapi library to version 0.15#40
Open
creativeprojects wants to merge 2 commits intomauer:mainfrom
Open
chore: upgrade hidapi library to version 0.15#40creativeprojects wants to merge 2 commits intomauer:mainfrom
creativeprojects wants to merge 2 commits intomauer:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR vendors an updated hidapi (0.15.0) into the project to address build issues with newer CMake versions and to pick up upstream backend improvements across Windows/macOS/Linux/*BSD.
Changes:
- Upgrade vendored
external/hidapito 0.15.0, including new/updated public APIs (e.g., output report sending and read-error reporting). - Update HIDAPI build/test assets (Windows descriptor reconstruction tests + new fixture data).
- Adjust CMake/autotools metadata/workflows inside the vendored HIDAPI tree.
Reviewed changes
Copilot reviewed 42 out of 45 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| CMakeLists.txt | Changes the top-level CMake minimum version. |
| external/hidapi/windows/test/hid_report_reconstructor_test.c | Updates MinGW formatting handling and parsing formats for indices. |
| external/hidapi/windows/test/data/1532_00A3_0002_0001_real.rpt_desc | Adds new Windows test fixture input descriptor dump. |
| external/hidapi/windows/test/data/1532_00A3_0002_0001_expected.rpt_desc | Adds expected reconstructed descriptor for new fixture. |
| external/hidapi/windows/test/data/1532_00A3_0002_0001.pp_data | Adds pp_data dump fixture for reconstruction tests. |
| external/hidapi/windows/test/data/045E_02FF_0005_0001_expected.rpt_desc | Updates expected output descriptor to match new reconstruction behavior. |
| external/hidapi/windows/test/CMakeLists.txt | Registers the new Windows reconstruction test case. |
| external/hidapi/windows/pp_data_dump/pp_data_dump.c | Updates pp_data dump formatting and MinGW handling. |
| external/hidapi/windows/hidapi_winapi.h | Adds WinAPI write-timeout API and clarifies doc naming. |
| external/hidapi/windows/hidapi_hidsdi.h | Extends HID DDI function typedefs (SetOutputReport). |
| external/hidapi/windows/hidapi_hidclass.h | Adds missing IOCTL macro definitions for broader SDK compatibility. |
| external/hidapi/windows/hidapi_descriptor_reconstruct.h | Updates descriptor reconstruction structures and adds layout assertion. |
| external/hidapi/windows/hidapi_descriptor_reconstruct.c | Refactors reconstruction implementation and padding logic. |
| external/hidapi/windows/hid.c | Implements new APIs and improves string/timeout/error handling. |
| external/hidapi/udev/69-hid.rules | Fixes a typo in rule comments. |
| external/hidapi/testgui/copy_to_bundle.sh | Adds bundle-copy helper script for macOS TestGUI. |
| external/hidapi/subprojects/hidapi_build_cmake/CMakeLists.txt | Updates CMake policy range syntax. |
| external/hidapi/src/CMakeLists.txt | Adds NetBSD backend wiring and conditional install logic. |
| external/hidapi/pc/hidapi-netbsd.pc.in | Adds pkg-config template for NetBSD backend. |
| external/hidapi/netbsd/hid.c | Adds new NetBSD UHID backend implementation. |
| external/hidapi/netbsd/README.md | Documents NetBSD backend design/constraints. |
| external/hidapi/netbsd/CMakeLists.txt | Adds NetBSD backend CMake target and install logic. |
| external/hidapi/mac/hid.c | Improves barrier implementation, error handling, and adds read-error API. |
| external/hidapi/mac/Makefile-manual | Removes AppKit dependency from manual build. |
| external/hidapi/mac/CMakeLists.txt | Removes AppKit, updates compatibility version logic, updates CMake range. |
| external/hidapi/linux/hid.c | Adds output-report ioctl support, read-error tracking, and robustness fixes. |
| external/hidapi/linux/CMakeLists.txt | Updates CMake version range. |
| external/hidapi/libusb/hidapi_thread_pthread.h | Introduces a thread abstraction header for pthread-based backends. |
| external/hidapi/libusb/hid.c | Refactors threading, enumeration, and adds output-report support hooks. |
| external/hidapi/libusb/CMakeLists.txt | Updates CMake range and fixes a typo in comments. |
| external/hidapi/hidtest/test.c | Updates test app to use new APIs and improved error output. |
| external/hidapi/hidtest/CMakeLists.txt | Updates CMake version range. |
| external/hidapi/hidapi/hidapi.h | Bumps HIDAPI minor version and adds/updates API docs and declarations. |
| external/hidapi/dist/hidapi.podspec | Removes AppKit dependency from CocoaPods spec. |
| external/hidapi/configure.ac | Removes AppKit dependency from autotools config. |
| external/hidapi/bootstrap | Adds bootstrap helper for autotools regeneration. |
| external/hidapi/VERSION | Updates version to 0.15.0. |
| external/hidapi/README.md | Updates CI badges/links. |
| external/hidapi/CMakeLists.txt | Updates CMake range and adds NetBSD option. |
| external/hidapi/BUILD.cmake.md | Updates documentation (typos + updated min CMake example + target alias name). |
| external/hidapi/BUILD.autotools.md | Updates autotools build instructions (out-of-source build). |
| external/hidapi/AUTHORS.txt | Fixes typo in maintenance wording. |
| external/hidapi/.github/workflows/docs.yaml | Updates GitHub Actions runners/actions and Doxygen installation approach. |
| external/hidapi/.github/workflows/checks.yml | Updates GitHub Actions runners/actions and package installation steps. |
| external/hidapi/.github/workflows/builds.yml | Updates CI flags, adds ClangCL job, and refreshes runners/actions and scripts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this PR?
I tried to compile the project on my mac:
With the latest version of
cmakefrom home-brew (cmake version 4.2.3) I wasn't able to compile the project with this error:What is this PR doing?
hidapilibrary from 0.14 to 0.15cmakeTesting