Skip to content

Add /api/v1/accounts & /api/v1/accounts/balance#12

Open
wabieth wants to merge 2 commits intomateodelnorte:masterfrom
wabieth:master
Open

Add /api/v1/accounts & /api/v1/accounts/balance#12
wabieth wants to merge 2 commits intomateodelnorte:masterfrom
wabieth:master

Conversation

@wabieth
Copy link
Copy Markdown

@wabieth wabieth commented Oct 1, 2014

I finally opted to add the support of

accounts:account_id\balance

method instead of

account\balance?account_id=

Note that I didn't upload the documentation, I'm not sure about what tool you use to generate it,

Let me know if you want me to make any change !

Cheers,

@mateodelnorte
Copy link
Copy Markdown
Owner

Hey @etiennetatur. I'm running the tests on this and getting the following fails.

Can you revisit and make sure your tests are still passing?

 1) coinbase.accounts.balance should return the user's account balance:

  CoinbaseError: Invalid account
      at Request._callback (/Users/matt/development/coinbase/lib/index.js:64:27)
      at Request.self.callback (/Users/matt/development/coinbase/node_modules/request/request.js:344:22)
      at Request.emit (events.js:98:17)
      at Request.<anonymous> (/Users/matt/development/coinbase/node_modules/request/request.js:1239:14)
      at Request.emit (events.js:117:20)
      at IncomingMessage.<anonymous> (/Users/matt/development/coinbase/node_modules/request/request.js:1187:12)
      at IncomingMessage.emit (events.js:117:20)
      at _stream_readable.js:944:16
      at process._tickCallback (node.js:442:13)

  2) coinbase.button should generate a new button:

  CoinbaseError: Merchant tools are disabled for this account. Please contact support.
      at Request._callback (/Users/matt/development/coinbase/lib/index.js:96:25)
      at Request.self.callback (/Users/matt/development/coinbase/node_modules/request/request.js:344:22)
      at Request.emit (events.js:98:17)
      at Request.<anonymous> (/Users/matt/development/coinbase/node_modules/request/request.js:1239:14)
      at Request.emit (events.js:117:20)
      at IncomingMessage.<anonymous> (/Users/matt/development/coinbase/node_modules/request/request.js:1187:12)
      at IncomingMessage.emit (events.js:117:20)
      at _stream_readable.js:944:16
      at process._tickCallback (node.js:442:13)

@wabieth
Copy link
Copy Markdown
Author

wabieth commented Mar 10, 2015

Hi Mateo,

Account balance : In the test you can specify an account id for the balance. I guess it could have been set up as a environment variable but it's not.

Coinbase button : Did you enable merchant tools on your account ?

@mateodelnorte
Copy link
Copy Markdown
Owner

Sounds like it should be made into an env variable. Can you refactor it into one and throw if it's not provided, similar to here: https://github.com/etiennetatur/coinbase/blob/master/test/index.js#L10 ?

@wabieth
Copy link
Copy Markdown
Author

wabieth commented Mar 10, 2015

Updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants