Develop#2189
Open
ievgen-nikiforov wants to merge 16 commits into
Open
Conversation
added 2 commits
May 5, 2026 12:53
brespect
suggested changes
May 5, 2026
brespect
left a comment
brespect
left a comment
There was a problem hiding this comment.
Good progress, but you need to pass all CI checks (tests & linter). Also, let's separate your App into smaller components
Author
fixed |
2pasha
suggested changes
May 5, 2026
2pasha
left a comment
2pasha
left a comment
There was a problem hiding this comment.
good job! 👏
fix linter warnings and take a look on comments below
Comment on lines
+19
to
+31
| export enum Filter { | ||
| All = 'All', | ||
| Active = 'Active', | ||
| Completed = 'Completed', | ||
| } | ||
| enum ErrorMessage { | ||
| Empty = '', | ||
| LoadError = 'Unable to load todos', | ||
| TitleError = 'Title should not be empty', | ||
| AddError = 'Unable to add a todo', | ||
| DeleteError = 'Unable to delete a todo', | ||
| UpdateError = 'Unable to update a todo', | ||
| } |
Comment on lines
+26
to
+57
| <a | ||
| href="#/" | ||
| data-cy="FilterLinkAll" | ||
| className={classNames('filter__link', { | ||
| selected: selectedFilter === Filter.All, | ||
| })} | ||
| onClick={() => onFilterChange(Filter.All)} | ||
| > | ||
| All | ||
| </a> | ||
|
|
||
| <a | ||
| href="#/active" | ||
| data-cy="FilterLinkActive" | ||
| className={classNames('filter__link', { | ||
| selected: selectedFilter === Filter.Active, | ||
| })} | ||
| onClick={() => onFilterChange(Filter.Active)} | ||
| > | ||
| Active | ||
| </a> | ||
|
|
||
| <a | ||
| href="#/completed" | ||
| data-cy="FilterLinkCompleted" | ||
| className={classNames('filter__link', { | ||
| selected: selectedFilter === Filter.Completed, | ||
| })} | ||
| onClick={() => onFilterChange(Filter.Completed)} | ||
| > | ||
| Completed | ||
| </a> |
There was a problem hiding this comment.
you may add all your filter values to enum and map through it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://ievgen-nikiforov.github.io/react_todo-app-with-api