Skip to content

last#4189

Open
doniliks wants to merge 3 commits intomate-academy:masterfrom
doniliks:master
Open

last#4189
doniliks wants to merge 3 commits intomate-academy:masterfrom
doniliks:master

Conversation

@doniliks
Copy link
Copy Markdown

@doniliks doniliks commented Apr 7, 2026

No description provided.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Great work on this task! Your solution correctly implements all the functional requirements, and the Sum component handles all prop variations perfectly. I am approving your submission.

I have one small suggestion for improvement in src/components/Sum/Sum.jsx. While your code works correctly, it's a best practice to use a single template literal for constructing strings with variables, as mentioned in the project checklist ([CHECKLIST ITEM #2]).

This improves readability. Here’s how you could write it:

<p>{`Sum of ${a} and ${b} is ${a + b}`}</p>

This is just a stylistic point to keep in mind for future tasks. Overall, this is a solid implementation. Keep it up!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

export const Sum = ({ a = 0, b = 0 }) => (
<div className="Card">
<p>
Sum of {a} and {b} is {a + b}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2. While this works, the good practice recommended in the checklist is to use a single template literal (string interpolation) for the entire text content. For example: {Sum of ${a} and ${b} is ${a + b}}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants