Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work on implementing the core functionality! The Sum component works correctly, and all requirements are met. However, one change is needed before this can be approved. In src/components/Sum/Sum.jsx, the string concatenation violates a project checklist item. Please use a template literal for better readability as required by [CHECKLIST ITEM #2].
Instead of:
<p>Sum of {a} and {b} is {a + b}</p>
Please change it to:
<p>{`Sum of ${a} and ${b} is ${a + b}`}</p>Once you make this adjustment, your solution will be perfect. Keep up the excellent effort!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/components/Sum/Sum.jsx
Outdated
| // export const Sum = () => (); | ||
| export const Sum = ({ a = 0, b = 0 }) => ( | ||
| <p> | ||
| Sum of {a} and {b} is {a + b} |
There was a problem hiding this comment.
This violates checklist item #2: 'Use string interpolation inside tag content'.
For better readability and to follow the project's code style, it's recommended to use a template literal here, like so:
<p>{`Sum of ${a} and ${b} is ${a + b}`}</p>
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this submission! I am approving your changes. You've successfully addressed the previous feedback by implementing the template literal in the Sum component. The code is now clean, concise, and fully meets all the task requirements. Great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
https://ruslanv23.github.io/react_sum/