Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job on creating the Sum component and correctly handling the default props! However, a couple of changes are needed before this can be approved.
The main issue is that src/App.jsx is incomplete. The task requires you to render five instances of the Sum component with different props, but currently, only one is being rendered. This is a core requirement, so please be sure to add all five specified component instances.
Additionally, in src/components/Sum/Sum.jsx, the string formatting violates a checklist item. Please use a single template literal for the output string for better readability, like this:
<p>{`Sum of ${a} and ${b} is ${a + b}`}</p>This addresses [CHECKLIST ITEM #2]. Once these changes are made, your solution will be ready for approval!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/App.jsx
Outdated
| {/* And remove commented lines :) */} | ||
| </> | ||
| ); | ||
| export const App = () => <Sum />; |
There was a problem hiding this comment.
The task description requires you to render five Sum components here with different sets of props. Currently, only one is being rendered.
src/components/Sum/Sum.jsx
Outdated
| // export const Sum = () => (); | ||
| export const Sum = ({ a = 0, b = 0 }) => ( | ||
| <p> | ||
| Sum of {a} and {b} is {a + b} |
There was a problem hiding this comment.
This violates checklist item #2: 'Use string interpolation inside tag content'. For better readability, please use a single template literal for the entire string: {Sum of ${a} and ${b} is ${a + b}}.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this update! I am approving your solution as you've successfully addressed all the feedback from the previous review. The App component now correctly includes all the required instances of the Sum component, and the Sum component itself is perfectly implemented using a template literal for the output. The code is clean, meets all requirements, and is ready to go. Great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
https://Dmytro-iT.github.io/react_sum/