Skip to content

add task solution#4183

Open
Ivadriil wants to merge 2 commits intomate-academy:masterfrom
Ivadriil:develop
Open

add task solution#4183
Ivadriil wants to merge 2 commits intomate-academy:masterfrom
Ivadriil:develop

Conversation

@Ivadriil
Copy link
Copy Markdown

@Ivadriil Ivadriil commented Apr 4, 2026

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Great job on implementing the Sum component! It correctly sets default props and renders the output as required. However, changes are needed in src/App.jsx to correctly test the default prop functionality. The task requires you to verify that the component uses its default values when props are omitted, but you are passing 0 explicitly. Please adjust your Sum component calls to omit the props that should be defaulted. For example, instead of <Sum a={10} b={0} />, you should use <Sum a={10} />, and instead of <Sum a={0} b={0} />, you should use <Sum />.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

src/App.jsx Outdated
Comment on lines +9 to +11
<Sum a={10} b={0} />
<Sum a={0} b={5} />
<Sum a={0} b={0} />
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal of these test cases is to verify that your Sum component correctly handles missing props by using default values. Instead of explicitly passing 0, you should omit the props as described in the task:

  • For just a = 10, use <Sum a={10} />.
  • For just b = 5, use <Sum b={5} />.
  • For 'no params at all', use <Sum />.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Excellent work on this pull request! I am approving your solution. You have successfully addressed all the feedback from the previous review, and the code now fully meets all task requirements. The implementation of the Sum component, including the handling of default props, is clean and correct. Well done!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants