Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
This requires changes. Your Sum component is implemented correctly with default props, which is great! However, the main issue is in src/App.jsx. The task requires you to demonstrate that the default props work by omitting them, but you are explicitly passing 0 instead.
For example:
- For the case with 'just
a = 10', the component should be called as<Sum a={10} />, not<Sum a={10} b={0} />. - For the case with no props, it should be
<Sum />.
Please update these calls in App.jsx to rely on the default props as described in the task.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/App.jsx
Outdated
| <Sum a={10} b={0} /> | ||
| <Sum a={0} b={5} /> | ||
| <Sum a={0} b={0} /> |
There was a problem hiding this comment.
According to the task description, you should rely on the default props of the Sum component for these cases. Instead of explicitly passing 0, you should omit the prop. For example, for 'just a = 10', the component should be called as <Sum a={10} />. Please update these lines to match the requirements for the cases where only one prop is passed or no props are passed.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this update! You've successfully addressed the feedback from the previous review. The App component now perfectly demonstrates how default props work by omitting them where necessary. The Sum component is also implemented cleanly, and your solution now meets all the task requirements. I am happy to approve this submission. Well done!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.