Skip to content

add task solution#4179

Open
nkoropka wants to merge 2 commits intomate-academy:masterfrom
nkoropka:develop
Open

add task solution#4179
nkoropka wants to merge 2 commits intomate-academy:masterfrom
nkoropka:develop

Conversation

@nkoropka
Copy link
Copy Markdown

@nkoropka nkoropka commented Apr 1, 2026

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Great job on the overall implementation! The Sum component works correctly, and you've handled the props and default values perfectly.

However, this submission requires a small change to meet all the task requirements. You've missed a specific code style guideline from the checklist. In src/components/Sum/Sum.jsx, the content of the <p> tag must be a single JavaScript expression using a template literal as per [CHECKLIST ITEM #2].

Please update it to use string interpolation like this:

<p>{`Sum of ${a} and ${b} is ${a + b}`}</p>

Once that's fixed, your solution will be perfect. Keep up the great work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

// export const Sum = () => ();
export const Sum = ({ a = 0, b = 0 }) => (
<p>
Sum of {a} and {b} is {a + b}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2. Please use string interpolation to construct the output string as shown in the task's good example. The content inside the <p> tag should be a single JavaScript expression: {`Sum of ${a} and ${b} is ${a + b}`}.

@@ -1,14 +1,13 @@
import React from 'react';
import './App.scss';
import { Sum } from './components/Sum/Sum';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Sum component you are importing here does not follow the code style guideline from checklist item #2. In src/components/Sum/Sum.jsx, you should use string interpolation (a template literal) for the content of the <p> tag. For example: {Sum of ${a} and ${b} is ${a + b}}.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Excellent work! You've successfully addressed the feedback from the previous review. The Sum component now correctly uses a template literal as required, and your solution fully meets all task requirements and code style guidelines. I am approving your submission. Great job!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants