Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
This is a great start, and the core functionality of the Sum component is working correctly! However, a couple of adjustments are needed to fully meet the task requirements.
- In
src/App.jsx, the component instance<Sum a={0} b={5} />doesn't test the default prop foraas intended. The requirement was to render a component with 'justb = 5', so please update this to<Sum b={5} />. - In
src/components/Sum/Sum.jsx, the output string should be constructed using a single template literal for better readability. This is a violation of a checklist item. Please change it to{`Sum of ${a} and ${b} is ${a + b}`}. [CHECKLIST ITEM #2]
Once you make these changes, your solution will be perfect. Keep up the excellent work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/components/Sum/Sum.jsx
Outdated
| // export const Sum = () => (); | ||
| export const Sum = ({ a = 0, b = 0 }) => ( | ||
| <p> | ||
| Sum of {a} and {b} is {a + b} |
There was a problem hiding this comment.
This implementation violates checklist item #2: 'Use string interpolation inside tag content'. For better readability, please use a single template literal to construct the string, like {`Sum of ${a} and ${b} is ${a + b}`}.
src/App.jsx
Outdated
| <Sum a={2} b={3} /> | ||
| <Sum a={-5} b={5} /> | ||
| <Sum a={10} /> | ||
| <Sum a={0} b={5} /> |
There was a problem hiding this comment.
The task description asks for a Sum component with 'just b = 5'. This is intended to test that the default prop for a is correctly applied when it's not provided. You should remove the a={0} prop and pass only b={5}.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this pull request! You've successfully addressed all the feedback from the previous review, and the code is now clean, correct, and fully meets all task requirements. The components are implemented perfectly. I am approving your solution, great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
DEMO LINK