Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Good work on the Sum component—the logic is correct and it handles the props as expected. However, this submission requires one change before it can be approved. The project checklist requires using string interpolation for creating content that mixes strings and variables [CHECKLIST ITEM #2]. In src/components/Sum/Sum.jsx, please update the <p> tag to use a template literal.
For example:
<p>{`${a} + ${b} = ${a + b}`}</p>This change will bring your code in line with the project's style guide. Please apply this fix.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/components/Sum/Sum.jsx
Outdated
| @@ -1 +1,3 @@ | |||
| // export const Sum = () => (); | |||
| export const Sum = ({a = 0, b = 0}) => ( | |||
| <p>Sum of {a} and {b} is {a + b}</p> | |||
There was a problem hiding this comment.
While this works, the checklist (item #2) recommends using string interpolation to create the content for the <p> tag. It can make the code a bit cleaner when mixing strings and variables.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this pull request! I am approving your solution. You've successfully addressed the feedback from the previous review by correctly using string interpolation for the sum text. The Sum component now fully meets all the task requirements and style guidelines. The code is clean, correct, and a great example of using props. Well done!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
DEMO LINK