Skip to content

Develop#970

Open
TaniaFedortsi wants to merge 11 commits into
mate-academy:masterfrom
TaniaFedortsi:develop
Open

Develop#970
TaniaFedortsi wants to merge 11 commits into
mate-academy:masterfrom
TaniaFedortsi:develop

Conversation

@TaniaFedortsi
Copy link
Copy Markdown

Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

demo link does not work. please fix it and re-request the review

Image

Copy link
Copy Markdown

@Denys-Kravchuk9988 Denys-Kravchuk9988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

One thing to improve:

  1. The pagination doesn't work when I try to click on 4th page
image

Copy link
Copy Markdown

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

To improve:

  1. These numbers should be synchronized
Image
  1. Add a link to your personal Github in the Github footer navbar link

Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job, but there are still some fixes you should make

  1. this card should link to the product page
Image
  1. add the active class to the selected color on the black theme
Image
  1. add a favicon and a title to the page
Image

Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants