Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job on structuring the application into components! The overall decomposition is well done. However, a couple of critical issues are preventing the application from working correctly, so some changes are needed.
First, the application fails to start because the Header and Article components are used in src/App.jsx but are not imported. Please add the corresponding import statements at the top of the file.
Second, a test is failing because some responsive styles for the Header are incorrectly located in src/components/Article/Article.css. To fix this and follow best practices, please move the .header styles from Article.css into Header.css.
Once these two issues are resolved, your solution should be good to go. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| <Header /> | ||
| <Article /> |
There was a problem hiding this comment.
The Header and Article components are used here, but they haven't been imported into this file. You need to import them at the top of the file, similar to how the Welcome component is imported.
src/components/Article/Article.css
Outdated
| .header { | ||
| text-align: left; | ||
| display: flex; | ||
| justify-content: space-between; | ||
| } |
There was a problem hiding this comment.
These styles for the .header class belong in the Header/Header.css file. Each component's CSS file should only contain styles that apply to that specific component.
2 participants
No description provided.