-
Notifications
You must be signed in to change notification settings - Fork 408
Add solution #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add solution #358
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| name: Test | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [ master ] | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [20.x] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: npm install | ||
| - run: npm test |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,88 @@ | ||
| 'use strict'; | ||
|
|
||
| const http = require('http'); | ||
| const fs = require('fs'); | ||
| const path = require('path'); | ||
|
|
||
| const PUBLIC_DIR = path.resolve(__dirname, '../public'); | ||
| const FILE_PREFIX = '/file'; | ||
|
|
||
| function sendText(response, statusCode, message) { | ||
| response.writeHead(statusCode, { | ||
| 'Content-Type': 'text/plain', | ||
| }); | ||
|
|
||
| response.end(message); | ||
| } | ||
|
|
||
| function createServer() { | ||
| /* Write your code here */ | ||
| // Return instance of http.Server class | ||
| return http.createServer((request, response) => { | ||
| const [pathname] = request.url.split('?'); | ||
|
|
||
| if (pathname === `${FILE_PREFIX}/`) { | ||
| const indexPath = path.join(PUBLIC_DIR, 'index.html'); | ||
|
|
||
| fs.readFile(indexPath, (error, fileContent) => { | ||
| if (error) { | ||
| sendText(response, 404, 'File was not found'); | ||
|
|
||
| return; | ||
| } | ||
|
|
||
| response.end(fileContent); | ||
| }); | ||
|
|
||
| return; | ||
| } | ||
|
|
||
| if (pathname === FILE_PREFIX) { | ||
| sendText( | ||
| response, | ||
| 200, | ||
| 'Use /file/<path> to load files from the public folder', | ||
| ); | ||
|
|
||
| return; | ||
| } | ||
|
|
||
| if (!pathname.startsWith(`${FILE_PREFIX}/`)) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The requirements state that for any path that doesn't start with |
||
| sendText(response, 400, 'Access outside public folder is forbidden'); | ||
|
|
||
| return; | ||
| } | ||
|
|
||
| const relativePath = | ||
| pathname.slice(`${FILE_PREFIX}/`.length) || 'index.html'; | ||
| const pathParts = relativePath.split('/'); | ||
|
|
||
| if ( | ||
| pathParts.some((part) => part === '..') || | ||
| relativePath.includes('\\') | ||
| ) { | ||
| sendText(response, 400, 'Access outside public folder is forbidden'); | ||
|
|
||
| return; | ||
| } | ||
|
|
||
| if (relativePath.includes('//')) { | ||
| sendText(response, 404, 'File was not found'); | ||
|
|
||
| return; | ||
| } | ||
|
|
||
| const normalizedPath = path.normalize(relativePath); | ||
| const filePath = path.join(PUBLIC_DIR, normalizedPath); | ||
|
|
||
| fs.readFile(filePath, (error, fileContent) => { | ||
| if (error) { | ||
| sendText(response, 404, 'File was not found'); | ||
|
|
||
| return; | ||
| } | ||
|
|
||
| response.end(fileContent); | ||
| }); | ||
| }); | ||
| } | ||
|
|
||
| module.exports = { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the task description, a request to
/fileshould serve thepublic/index.htmlfile. This logic currently returns a text hint instead. The behavior for the/filepath should be the same as it is for/file/.