Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/test.yml-template
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"devDependencies": {
"@faker-js/faker": "^8.4.1",
"@mate-academy/eslint-config": "latest",
"@mate-academy/scripts": "^1.8.6",
"@mate-academy/scripts": "^2.1.3",
"axios": "^1.7.2",
"eslint": "^8.57.0",
"eslint-plugin-jest": "^28.6.0",
Expand Down
84 changes: 82 additions & 2 deletions src/createServer.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,88 @@
'use strict';

const http = require('http');
const fs = require('fs');
const path = require('path');

const PUBLIC_DIR = path.resolve(__dirname, '../public');
const FILE_PREFIX = '/file';

function sendText(response, statusCode, message) {
response.writeHead(statusCode, {
'Content-Type': 'text/plain',
});

response.end(message);
}

function createServer() {
/* Write your code here */
// Return instance of http.Server class
return http.createServer((request, response) => {
const [pathname] = request.url.split('?');

if (pathname === `${FILE_PREFIX}/`) {
const indexPath = path.join(PUBLIC_DIR, 'index.html');

fs.readFile(indexPath, (error, fileContent) => {
if (error) {
sendText(response, 404, 'File was not found');

return;
}

response.end(fileContent);
});

return;
}

if (pathname === FILE_PREFIX) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the task description, a request to /file should serve the public/index.html file. This logic currently returns a text hint instead. The behavior for the /file path should be the same as it is for /file/.

sendText(
response,
200,
'Use /file/<path> to load files from the public folder',
);

return;
}

if (!pathname.startsWith(`${FILE_PREFIX}/`)) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requirements state that for any path that doesn't start with /file/, the server should return a helpful hint message. This implementation incorrectly returns a '400 Forbidden' error. The hint should guide the user on how to correctly use the /file/ endpoint.

sendText(response, 400, 'Access outside public folder is forbidden');

return;
}

const relativePath =
pathname.slice(`${FILE_PREFIX}/`.length) || 'index.html';
const pathParts = relativePath.split('/');

if (
pathParts.some((part) => part === '..') ||
relativePath.includes('\\')
) {
sendText(response, 400, 'Access outside public folder is forbidden');

return;
}

if (relativePath.includes('//')) {
sendText(response, 404, 'File was not found');

return;
}

const normalizedPath = path.normalize(relativePath);
const filePath = path.join(PUBLIC_DIR, normalizedPath);

fs.readFile(filePath, (error, fileContent) => {
if (error) {
sendText(response, 404, 'File was not found');

return;
}

response.end(fileContent);
});
});
}

module.exports = {
Expand Down
Loading