Conversation
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on December 5. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
|
Warning Rate limit exceeded@matdev83 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 46 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if content.is_done or content.is_cancellation: | ||
| with _fallback_lock: | ||
| fallback_key = _reverse_stream_keys.pop(stream_id, None) | ||
| if fallback_key is not None: | ||
| _active_stream_ids.pop(fallback_key, None) |
There was a problem hiding this comment.
Clean stale fallback stream mapping when real id arrives
When a stream starts without stream_id, this function stores a generated UUID in _active_stream_ids and _reverse_stream_keys. If later chunks include an explicit stream_id or request_id, the loop above returns that explicit value, but the cleanup here uses the new identifier to pop the reverse map. The original UUID entry is never removed, so future streams that only carry the same session metadata will reuse the stale UUID and share buffers, and the dictionaries leak entries indefinitely. Consider removing or updating the fallback mapping whenever the resolved stream_id differs from the recorded fallback value.
Useful? React with 👍 / 👎.
Summary
get_stream_idto prefer request-level metadata and maintain per-key identifiers when no explicit stream id is providedTesting
Codex Task