Conversation
…w-telemed-and-in-person-visits-on-a-single-tracking-board
…w-telemed-and-in-person-visits-on-a-single-tracking-board
…w-telemed-and-in-person-visits-on-a-single-tracking-board
…w-telemed-and-in-person-visits-on-a-single-tracking-board
…w-telemed-and-in-person-visits-on-a-single-tracking-board
| ? 'In Person' | ||
| : appointment.appointmentAttendanceType === 'virtual' | ||
| ? 'Virtual' | ||
| : 'Unknown'}{' '} |
Contributor
There was a problem hiding this comment.
Did we previously have an "unknown" category in the UI? If not, we probably shouldn’t introduce it now, and instead we can add Sentry logging to detect these errors.
Also, it could be useful to extract helpers (or a component) that determine all state based on whether the visit is in-person or virtual. This would help avoid ternary expressions and simplify the code. There are several places in this PR where this approach could be applied.
Contributor
Author
There was a problem hiding this comment.
I've added a helper function to check whether an appointment is virtual.
…w-telemed-and-in-person-visits-on-a-single-tracking-board
ValeriyDyachenko
approved these changes
Apr 13, 2026
VladMstv
deleted the
bholyshevskyi/otr-2096-show-telemed-and-in-person-visits-on-a-single-tracking-board
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/zapehr/issue/OTR-2096/show-telemed-and-in-person-visits-on-a-single-tracking-board