Refactor: replace orientation-specific branches with general-purpose axis mapping#22
Closed
Refactor: replace orientation-specific branches with general-purpose axis mapping#22
Conversation
…axis mapping Introduce getAxes() utility that maps orientation to primary/cross axis property keys, eliminating duplicated horizontal/vertical branching in calculateLayoutRects, calculateMinSize, getSurroundingRect, and calculateResizeRatio. Each function now uses a single code path that works for both orientations. https://claude.ai/code/session_016Q7JGGCYmDSC89FKb5xhPH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce getAxes() utility that maps orientation to primary/cross axis
property keys, eliminating duplicated horizontal/vertical branching in
calculateLayoutRects, calculateMinSize, getSurroundingRect, and
calculateResizeRatio. Each function now uses a single code path that
works for both orientations.
https://claude.ai/code/session_016Q7JGGCYmDSC89FKb5xhPH