Conversation
Extract directionToSplitConfig() helper to centralize the knowledge of how directions map to orientations and child ordering. Previously this mapping was duplicated in createSplitNode() and the movePanel() sibling swap, requiring parallel updates if the semantics changed. https://claude.ai/code/session_018Xj6MY17i4o6N1Eg2ch9st
Keep types.ts as a pure type-only module and colocate the helper with its only consumers. https://claude.ai/code/session_018Xj6MY17i4o6N1Eg2ch9st
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract directionToSplitConfig() helper to centralize the knowledge of
how directions map to orientations and child ordering. Previously this
mapping was duplicated in createSplitNode() and the movePanel() sibling
swap, requiring parallel updates if the semantics changed.
https://claude.ai/code/session_018Xj6MY17i4o6N1Eg2ch9st