Refactor LayoutTree from class to functional API#16
Closed
Conversation
Replace LayoutTree class wrapper with standalone findNode, findParentNode, and replaceChildNode functions. The class only held a root reference that LayoutManager already owns, making it a shallow module with unnecessary indirection. LayoutManager now owns root state directly and passes it to tree utility functions. https://claude.ai/code/session_01QFjTD3NY8jFj2Gm63KUREV
mass2527
force-pushed
the
claude/review-module-design-fVmA2
branch
from
e8391b6 to
d29490e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converted the
LayoutTreeclass into a functional API with standalone exported functions, eliminating the need for class instantiation and simplifying the codebase.Key Changes
LayoutTreeclass: Replaced the class-based approach with functional exports (findNode,findParentNode,replaceChildNode)LayoutManager: Changed from storing aLayoutTreeinstance (_tree) to directly storing the root node (_root), passing it as a parameter to utility functionsLayoutManagerand test files to use the new functional APIfindParentNode: Made the existing utility function available as a public export fromLayoutTree.tsImplementation Details
findNodeandreplaceChildNodefunctions now acceptroot: LayoutNode | nullas their first parameterfindNodeInSubTreehelper remains private but is now a standalone functionhttps://claude.ai/code/session_01QFjTD3NY8jFj2Gm63KUREV