Fix failing tests which use Test::Data::Scalar#2
Open
netangel wants to merge 1 commit into
Open
Conversation
Using dependencies from Makefile.pl we install Test::Data but as it defined as Test::Data::Scalar in Makefile some tests are failing with: Undefined subroutine &Test::Data::Scalar::ref_type_ok called I've checked this issue on Mac OS X (10.9) and Ubuntu linux (14.14) Also "use strict" and "use warnings" were added to improve Kwalitee :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I have been received your module as CPAN PRC (Pull request challenge).
I've checked the issue about using Moo instead of Any::Mouse, but it doesn't make any sense for me, cause Any::Moose is being used only for tests, which is suitable enough.
BTW, while playing with your code, I've found some issues with tests. Here is the commit description:
Using dependencies from Makefile.pl we install Test::Data, but, since it's used as Test::Data::Scalar in Makefile, some tests are failing with:
I've checked this issue on Mac OS X (10.9) and Ubuntu linux (14.14).
Changing dependency for tests to Test::Data is fixing this issue.
Also "use strict" and "use warnings" were added to improve Kwalitee :)