Fix: programmatic image uploads fail when ImageContentInterface::NAME has no extension#5
Open
milorad-smartweb wants to merge 1 commit intomarkshust:mainfrom
Conversation
… has no extension
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3
Problem
When images are assigned programmatically via
Product::addImageToMediaGallery()(e.g. CLI import), Magento core stores
ImageContentInterface::NAMEas$pathinfo['filename']— without a file extension.During
productRepository::save(),MediaGalleryProcessorpasses this name toImageProcessor::processImageContent(). The Uploader then validates the extensionof the
namefield against the allowlist set by this plugin. Since the name has noextension,
''is not in['jpg', 'jpeg', 'gif', 'png']and the upload is rejected.The exception is silently caught,
getUploadedFileName()returns null, and asubsequent
processor->addImage()call throws "The image doesn't exist".Fix
Before setting allowed extensions on the Uploader, check whether the image content
name already has an extension. If not, derive it from the MIME type (which Magento
has already validated at this point) and set it on the content object. This ensures
both programmatic and form-based uploads pass the extension check without any
reduction in security.
Testing
addImageToMediaGallery: no longer throws "The image doesn't exist"