Skip to content

Comments

MLE-12345 Unrevert new optic changes#1065

Merged
stevebio merged 4 commits intodevelopfrom
unrevert_new_optic_changes
Feb 24, 2026
Merged

MLE-12345 Unrevert new optic changes#1065
stevebio merged 4 commits intodevelopfrom
unrevert_new_optic_changes

Conversation

@stevebio
Copy link
Collaborator

Unrevert the reverts for the new Optic functions: transitiveClosure, vec.trun and vec.precision, and fromDocs.

Copilot AI review requested due to automatic review settings February 23, 2026 21:36
@github-actions
Copy link

github-actions bot commented Feb 23, 2026

Copyright Validation Results
Total: 11 | Passed: 8 | Failed: 0 | Skipped: 3 | at: 2026-02-23 23:52:18 UTC | commit: 27a145d

⏭️ Skipped (Excluded) Files

  • test-app/src/main/ml-data/optic/transitive-closure/collections.properties
  • test-app/src/main/ml-data/optic/transitive-closure/permissions.properties
  • test-app/src/main/ml-data/optic/transitive-closure/transClosureTripleSet.xml

✅ Valid Files

  • lib/plan-builder-base.js
  • lib/plan-builder-generated.js
  • test-basic/optic-fromDocs.js
  • test-basic/optic-vector.js
  • test-basic/plan-builder-generated.js
  • test-basic/service-caller.js
  • test-basic/ssl-min-allow-tls-test.js
  • test-basic/transitive-closure.js

✅ All files have valid copyright headers!

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR unreverts previously reverted changes that add new Optic functions for MarkLogic Server 12: transitiveClosure, vec.trunc, vec.precision, and fromDocs. These functions enhance graph traversal capabilities, vector operations, and dynamic document-to-row mapping.

Changes:

  • Added transitiveClosure method for graph-like structure traversal with configurable path length constraints
  • Added vec.trunc and vec.precision functions for vector element manipulation
  • Added fromDocs function with columnBuilder and context helpers for dynamic document mapping without TDE templates
  • Updated VecVector type handling in plan-builder-base.js to return the ServerType object instead of unwrapping it
  • Added comprehensive test coverage for all new functions with test data

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
lib/plan-builder-generated.js Implementation of new Optic functions: transitiveClosure, vec.trunc, vec.precision, fromDocs, columnBuilder, and context with JSDoc documentation
lib/plan-builder-base.js Updated castArg logic to properly handle VecVector ServerType and added PlanTransitiveClosureOptions validation
test-basic/transitive-closure.js New test suite for transitiveClosure with 5 test cases covering various path length configurations
test-basic/optic-vector.js Updated and expanded vector function tests including new tests for vec.trunc and vec.precision
test-basic/optic-fromDocs.js New comprehensive test suite for fromDocs with 6 test cases covering basic usage, defaults, expressions, geospatial queries, and vector operations
test-basic/plan-builder-generated.js Updated vec.base64Decode test with corrected test data and improved documentation
test-basic/ssl-min-allow-tls-test.js Increased timeout from 10000ms to 12000ms to accommodate slower TLS configuration changes
test-basic/service-caller.js Skipped failing test with comment indicating it needs fixing
test-app/src/main/ml-data/optic/transitive-closure/transClosureTripleSet.xml Test data: RDF triples representing parent-child relationships for transitive closure tests
test-app/src/main/ml-data/optic/transitive-closure/permissions.properties Test data permissions configuration
test-app/src/main/ml-data/optic/transitive-closure/collections.properties Test data collection assignments

Fix copyright end year and fix some JSDoc typos and incorrect statements caught by Copilot
Copy link
Contributor

@rjrudin rjrudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good, but the develop branch is already broken due to npm audit failing. This PR isn't going to affect that, so go ahead and merge this and then do a separate PR for fixing the audit failures - Copilot should be able to bump the dependencies based on each failure.

@stevebio stevebio merged commit 562abe4 into develop Feb 24, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants