PDP-536: Adding copyright check#254
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds copyright header validation to the pull request workflow by integrating a reusable copyright check workflow from the marklogic/pr-workflows repository.
- Adds a new job
copyright-validationto the existing PR workflow - Creates a configuration file
.copyrightconfigto define copyright validation rules - Updates the workflow name from "🏷️ JIRA ID Validator" to "PR Workflow"
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/pr-workflow.yaml | Adds copyright validation job and updates workflow name |
| .copyrightconfig | Defines copyright validation configuration with start year and file exclusions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| # - Dotfiles already skipped automatically | ||
| # Enable by removing the leading '# ' from the next line and editing values. | ||
| # filesexcluded: third_party/*, docs/generated/*.md, assets/*.png, scripts/temp_*.py, vendor/lib.js | ||
| filesexcluded: .github/*, README.md, Jenkinsfile, gradle/*, docker-compose.yml, *.gradle, gradle.properties, gradlew, gradlew.bat |
There was a problem hiding this comment.
[nitpick] This exclusion list is quite extensive and contains many different types of files. Consider organizing this into multiple lines or adding comments to explain why each file type is excluded to improve maintainability.
Suggested change
| filesexcluded: .github/*, README.md, Jenkinsfile, gradle/*, docker-compose.yml, *.gradle, gradle.properties, gradlew, gradlew.bat | |
| # Exclude CI/CD and configuration files | |
| # - .github/*: GitHub workflows and configs | |
| # - Jenkinsfile: Jenkins pipeline config | |
| # - docker-compose.yml: Docker Compose config | |
| # - README.md: Project documentation | |
| # Exclude Gradle build files and scripts | |
| # - gradle/*: Gradle wrapper and scripts | |
| # - *.gradle: Gradle build scripts | |
| # - gradle.properties: Gradle properties | |
| # - gradlew, gradlew.bat: Gradle wrapper executables | |
| filesexcluded: \ | |
| .github/*, \ | |
| README.md, \ | |
| Jenkinsfile, \ | |
| gradle/*, \ | |
| docker-compose.yml, \ | |
| *.gradle, \ | |
| gradle.properties, \ | |
| gradlew, \ | |
| gradlew.bat |
BillFarber
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.