Skip to content

PDP-536: Adding copyright check#254

Merged
rjrudin merged 1 commit into
marklogic:developfrom
SameeraPriyathamTadikonda:develop
Oct 8, 2025
Merged

PDP-536: Adding copyright check#254
rjrudin merged 1 commit into
marklogic:developfrom
SameeraPriyathamTadikonda:develop

Conversation

@SameeraPriyathamTadikonda
Copy link
Copy Markdown

No description provided.

Copilot AI review requested due to automatic review settings August 27, 2025 00:27
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds copyright header validation to the pull request workflow by integrating a reusable copyright check workflow from the marklogic/pr-workflows repository.

  • Adds a new job copyright-validation to the existing PR workflow
  • Creates a configuration file .copyrightconfig to define copyright validation rules
  • Updates the workflow name from "🏷️ JIRA ID Validator" to "PR Workflow"

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/pr-workflow.yaml Adds copyright validation job and updates workflow name
.copyrightconfig Defines copyright validation configuration with start year and file exclusions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .copyrightconfig
# - Dotfiles already skipped automatically
# Enable by removing the leading '# ' from the next line and editing values.
# filesexcluded: third_party/*, docs/generated/*.md, assets/*.png, scripts/temp_*.py, vendor/lib.js
filesexcluded: .github/*, README.md, Jenkinsfile, gradle/*, docker-compose.yml, *.gradle, gradle.properties, gradlew, gradlew.bat
Copy link

Copilot AI Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] This exclusion list is quite extensive and contains many different types of files. Consider organizing this into multiple lines or adding comments to explain why each file type is excluded to improve maintainability.

Suggested change
filesexcluded: .github/*, README.md, Jenkinsfile, gradle/*, docker-compose.yml, *.gradle, gradle.properties, gradlew, gradlew.bat
# Exclude CI/CD and configuration files
# - .github/*: GitHub workflows and configs
# - Jenkinsfile: Jenkins pipeline config
# - docker-compose.yml: Docker Compose config
# - README.md: Project documentation
# Exclude Gradle build files and scripts
# - gradle/*: Gradle wrapper and scripts
# - *.gradle: Gradle build scripts
# - gradle.properties: Gradle properties
# - gradlew, gradlew.bat: Gradle wrapper executables
filesexcluded: \
.github/*, \
README.md, \
Jenkinsfile, \
gradle/*, \
docker-compose.yml, \
*.gradle, \
gradle.properties, \
gradlew, \
gradlew.bat

Copilot uses AI. Check for mistakes.
@rjrudin rjrudin merged commit d74111a into marklogic:develop Oct 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants