Github Pages Publish Fixes#250
Merged
Merged
Conversation
Set github-pages Gem version to latest: 232. Delete Gemfile.lock. Should be ignored for Github Pages standard Jekyll Add Gemfile.lock to docs/.gitignore Remove custom jekyll workflow action. For NiFi docs, using standard Jekyll publish action.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GitHub Pages Gem version in the docs Gemfile and aligns the configuration with the standard Jekyll publish action.
- Update GitHub Pages Gem version from "
> 228" to "> 232" - Supports removal of custom Jekyll workflow action referenced in the description
Files not reviewed (2)
- .github/workflows/jekyll-gh-pages.yml: Language not supported
- docs/.gitignore: Language not supported
Author
|
I have configured Github Pages to publish from the fixGhPagesPubError branch for the moment. The test worked, it published fine to nifi docs URL. |
stevebio
changed the title
rjrudin
approved these changes
May 19, 2025
rjrudin
left a comment
rjrudin
left a comment
There was a problem hiding this comment.
Based on https://github.com/marklogic/nifi/actions/runs/15098416667 , it looks like this worked? In which case - just set the GH Pages setting back to "main" for the branch that it publishes from.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set github-pages Gem version to latest: 232.
Delete Gemfile.lock. Should be ignored for Github Pages standard Jekyll pages-build-deployment workflow.
Add Gemfile.lock to docs/.gitignore.
Remove custom jekyll workflow. For NiFi docs, using standard pages-build-deployment workflow.