PDP-1182 SECCMP-1797: Add top-level permissions to restrict default token#255
Open
GAdityaVarma wants to merge 2 commits intodevelopfrom
Open
PDP-1182 SECCMP-1797: Add top-level permissions to restrict default token#255GAdityaVarma wants to merge 2 commits intodevelopfrom
GAdityaVarma wants to merge 2 commits intodevelopfrom
Conversation
Adds explicit top-level permissions: contents: read to limit the default GITHUB_TOKEN scope for all jobs. Individual jobs that need write access (copyright-validation) already declare their own permissions block which overrides the default. This follows the principle of least privilege recommended in GitHub's PwnRequest security guidance.
GAdityaVarma
requested review from
BillFarber,
rjrudin and
stevebio
as code owners
There was a problem hiding this comment.
Pull request overview
This PR tightens GitHub Actions security for the pull_request_target workflow by restricting the default GITHUB_TOKEN permissions at the workflow level, reducing exposure to unintended write-scoped token usage across jobs.
Changes:
- Adds a top-level
permissionsblock settingcontents: readfor the workflow. - Keeps the
copyright-validationjob’s explicit permission overrides intact.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rjrudin
approved these changes
Apr 8, 2026
GAdityaVarma
changed the title
Contributor
|
@GAdityaVarma Let's remove this workflow from this repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SECCMP-1797: Add top-level permissions to restrict default token
Adds
permissions: contents: readat the workflow level to restrict the default GITHUB_TOKEN scope. Without this, all jobs inherit the fullpull_request_targetwrite token.The
copyright-validationjob already declares its ownpermissionsblock which overrides the default for that specific job.Ref: Preventing pwn requests