MLE-26918 Dropping eval implementation for incremental write#1909
Merged
MLE-26918 Dropping eval implementation for incremental write#1909
Conversation
Also renamed the other two classes to make it clear what their distinction is - fromLexicons and fromView
|
Copyright Validation Results ✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull request overview
This PR removes the eval-based implementation for incremental write filtering and renames the remaining filter classes to clearly distinguish between the fromLexicons and fromView approaches. Additionally, it refactors IncrementalWriteConfig from a traditional class to a Java record, which simplifies the code and removes boilerplate getter methods.
Changes:
- Removed the eval-based query implementation (IncrementalWriteEvalFilter class and useEvalQuery builder method)
- Renamed filter classes: IncrementalWriteOpticFilter → IncrementalWriteFromLexiconsFilter, IncrementalWriteViewFilter → IncrementalWriteFromViewFilter
- Converted IncrementalWriteConfig from a class with getters to a record with accessor methods
- Extracted duplicate URI extraction logic into a shared getUrisInBatch method
- Removed tests for the eval implementation and updated test names to reflect the new naming convention
- Added
@sincejavadoc annotation to FilterException
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| IncrementalWriteTest.java | Removed eval-related tests and renamed test methods to reflect the new filter naming (fromView and fromLexicons) |
| IncrementalWriteFromViewFilter.java | Renamed from IncrementalWriteViewFilter, refactored to use getUrisInBatch helper and record accessor methods |
| IncrementalWriteFromLexiconsFilter.java | Renamed from IncrementalWriteOpticFilter, refactored to use getUrisInBatch helper and record accessor methods |
| IncrementalWriteFilter.java | Removed useEvalQuery builder method, updated to instantiate renamed classes, converted to use record accessor methods, added getUrisInBatch helper |
| IncrementalWriteEvalFilter.java | Completely removed file containing the eval-based implementation |
| IncrementalWriteConfig.java | Converted from traditional class to Java record with custom canonical constructor for xmlNamespaces handling |
| FilterException.java | Added @since 8.1.0 javadoc annotation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BillFarber
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also renamed the other two classes to make it clear what their distinction is - fromLexicons and fromView