freebsd-regression-test-suite: use comma-separated list for tests

[svmhdvn]

This makes it so much easier to write tooling on top of bricoler, due to very complicated shell space quoting rules.

[markjdb]

I'm fine with it, but does this break any scripts using the old syntax? I think not?

[svmhdvn]

No, because there are no tests with , in them.

[markjdb]

No, because there are no tests with , in them.

No I mean, if someone has a script which runs with --freebsd-regression-test-suite/tests="foo bar", it'll still work as before I think?

[svmhdvn]

Sorry, never mind, it looks like there are 4+ tests with commas in them:

sys/netlink/test_rtnl_ifaddr.py:TestRtNlIfaddrOpsBroadcast::test_add_6_flags[autoconf,deprecated]  ->  passed  [0.290s] 

sys/netlink/test_rtnl_ifaddr.py:TestRtNlIfaddrOpsP2p::test_del[ifa_addr=addr,ifa_local=addr-ip6_dst_outside_128]  ->  passed  [0.325s] 

sys/netlink/test_rtnl_ifaddr.py:TestRtNlIfaddrOpsP2p::test_del[ifa_addr=addr,ifa_local=addr-ipv4_dst_inside_30]  ->  passed  [0.286s] 

sys/netlink/test_rtnl_ifaddr.py:TestRtNlIfaddrOpsP2p::test_del[ifa_addr=addr,ifa_local=addr-ipv4_dst_outside_32]  ->  passed  [0.297s]

I'll have to rethink this, in case someone wants to pass this in as a custom test.

[svmhdvn]

No, because there are no tests with , in them.

No I mean, if someone has a script which runs with --freebsd-regression-test-suite/tests="foo bar", it'll still work as before I think?

Yes this has backwards compatibility as well, replace() will only replace commas.

[markjdb]

Sorry, never mind, it looks like there are 4+ tests with commas in them:

sys/netlink/test_rtnl_ifaddr.py:TestRtNlIfaddrOpsBroadcast::test_add_6_flags[autoconf,deprecated]  ->  passed  [0.290s] 

sys/netlink/test_rtnl_ifaddr.py:TestRtNlIfaddrOpsP2p::test_del[ifa_addr=addr,ifa_local=addr-ip6_dst_outside_128]  ->  passed  [0.325s] 

sys/netlink/test_rtnl_ifaddr.py:TestRtNlIfaddrOpsP2p::test_del[ifa_addr=addr,ifa_local=addr-ipv4_dst_inside_30]  ->  passed  [0.286s] 

sys/netlink/test_rtnl_ifaddr.py:TestRtNlIfaddrOpsP2p::test_del[ifa_addr=addr,ifa_local=addr-ipv4_dst_outside_32]  ->  passed  [0.297s]

I'll have to rethink this, in case someone wants to pass this in as a custom test.

What's your larger goal here? Maybe we can incorporate it more directly into bricoler somehow.