VMRun: allow running riscv64 guests with RVVM#17
VMRun: allow running riscv64 guests with RVVM#17markjdb merged 2 commits intomarkjdb:master-pythonfrom
Conversation
markjdb
left a comment
There was a problem hiding this comment.
I'm ok with this if we avoid silently disabling network in RVVM.
0a57191 to
ce562ba
Compare
|
Split out the other unrelated commits, will post PRs for those separately. I've added a NetworkDriver.NONE enum value, that should handle the feedback you mentioned. Let me know if this looks good. |
|
Is the intent to use RVVM for running the regression test suite? The lack of networking means that we can't fetch the kyua report using scp. |
|
Looks ok to me in any case. |
|
(but there are some conflicts, sorry) |
RVVM has networking enabled by default, The |
ce562ba to
bdffc9e
Compare
But we want to configure a specific address/port for ssh access, see |
With this, we can choose to disable networking in VMs.
bdffc9e to
5e28506
Compare
RVVM seems to have a significant performance advantage over QEMU.
5e28506 to
7c70751
Compare
Thanks for this info, I've updated it now to properly port forward the ssh addr and port. I've tested this with #22 and it works well. |
See individual commits.
NOTE: RVVM support requires upstream RVVM, not the current
emulators/rvvmfreebsd port. Currently pending the addition ofemulators/rvvm-develtracking upstream HEAD.