when refreshing, stellar needs to use updated data-background-ratio#99
Open
spapin wants to merge 2 commits intomarkdalgleish:masterfrom
spapin:master
Open
when refreshing, stellar needs to use updated data-background-ratio#99spapin wants to merge 2 commits intomarkdalgleish:masterfrom spapin:master
spapin wants to merge 2 commits intomarkdalgleish:masterfrom
spapin:master
Conversation
…lue is used if the attribute is modified after stellar is first instanciated.
Author
|
Updates on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed: when an ratio attribute is dynamically changed, it is not taken into account by stellar('refresh')
The problem is solved by reading directly the attribute value upon refresh.
Fixes issue #77