Skip to content

Fix TypeError in oidInSubtree when varbind OID is null #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aarena-domotz wants to merge 11 commits into from
+5 −7
Closed

Fix TypeError in oidInSubtree when varbind OID is null #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d0117d9
fix dependencies. Replace package name with an alias to support insta…
andreaazzara Jun 22, 2020
98e2d41
Merge branch 'master' of https://github.com/markabrahams/node-net-snmp
andreaazzara Jun 22, 2020
fa9c76e
[fix_syntax_for_node_6.9.2] US-2804: patch for node 6.9.2 compatible …
faustothegrey Jun 30, 2020
e07ae71
Merge pull request #1 from domotz/fix_syntax_for_node_6.9.2
faustothegrey Jun 30, 2020
6584151
[fix_syntax_for_node_6.9.2] US-2804: patch for node 6.9.2 compatible …
faustothegrey Jun 30, 2020
e8eabae
Merge pull request #2 from domotz/fix_syntax_for_node_6.9.2
faustothegrey Jun 30, 2020
f063978
merged markabrahamsmaster
alessandrolulli Jun 9, 2022
dcfb72c
support node 6.8.2
alessandrolulli Jul 4, 2022
2544879
Merge pull request #4 from domotz/3.8.1domotz02
alessandrolulli Jul 4, 2022
de074a3
Fix TypeError in oidInSubtree when varbind OID is null
aarena-domotz Mar 19, 2026
70b43ea
Merge branch 'master' into fix/oid-in-subtree-null-guard
aarena-domotz Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
node_modules
package-lock.json
notes.txt
example/test.js
node-net-snmp.iml
7 changes: 4 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,7 @@ function oidFollowsOid (oidString, nextString) {
}

function oidInSubtree (oidString, nextString) {
if (!nextString) return false;
var oid = oidString.split (".");
var next = nextString.split (".");

Expand Down Expand Up @@ -1307,7 +1308,7 @@ Authentication.calculateDigest = function (messageBuffer, authProtocol, authPass
var hmacAlgorithm = crypto.createHmac (cryptoAlgorithm, authKey);
hmacAlgorithm.update (messageBuffer);
var digest = hmacAlgorithm.digest ();
return digest.subarray (0, Authentication.algorithms[authProtocol].AUTHENTICATION_CODE_LENGTH);
return Buffer.from(digest.subarray (0, Authentication.algorithms[authProtocol].AUTHENTICATION_CODE_LENGTH));
};

var Encryption = {};
Expand Down Expand Up @@ -1778,9 +1779,9 @@ Message.prototype.checkAuthentication = function (user, responseCb) {
Message.prototype.setMsgFlags = function (bitPosition, flag) {
if ( this.msgGlobalData && this.msgGlobalData !== undefined && this.msgGlobalData !== null ) {
if ( flag ) {
this.msgGlobalData.msgFlags = this.msgGlobalData.msgFlags | ( 2 ** bitPosition );
this.msgGlobalData.msgFlags = this.msgGlobalData.msgFlags | ( Math.pow(2, bitPosition) );
} else {
this.msgGlobalData.msgFlags = this.msgGlobalData.msgFlags & ( 255 - 2 ** bitPosition );
this.msgGlobalData.msgFlags = this.msgGlobalData.msgFlags & ( 255 - Math.pow(2, bitPosition) );
}
}
};
Expand Down