Function can send String, and standard command can be disabled#140
Function can send String, and standard command can be disabled#140lucalas wants to merge 1 commit intomarcoschwartz:masterfrom lucalas:lucalas-patch-1
Conversation
…...) can be disabled I changed the return value of a function to return a string to client so we can send json for example. I thought that if i expose my api in internet, normal commands like analog, digital and mode, would be really insecure, so i added a define that help us to attach and detach them.
|
why is this pr closed? Return a json object from function would be rad ? @lucalas are you using this atm? |
|
@gorhgorh the build didn't work at all, just for the case that i'm able to test. At the moment I'm not able to build and test all cases to verify travis tests and i don't use Arduino board anymore, however I can try to recreate the pool request if you think could be a good feature. |
|
thanks for your comments, I'll have a look a this PR |
|
@gorhgorh let me know if you have any question on the function returning string. I'm the one who did the PR. Happy to help you if needed. |
|
thanks @Ellerbach, too bad this is pr is not merged, i see so many case where getting data as return of a function avoid having to expose, and make a request to a variable, as we had to do in the project we are using aRest with |
|
Indeed, I am not sure about why this PR request was closed. If anyone want to submit a new one you are welcome to do so :) |
4 participants
Function can send String, and standard command can be disabled (analog, digital, mode).
I changed the return value of a function to return a string to client so we can send json for example instead of an integer.
In addition I thought that if i expose my api in internet, normal commands like analog, digital and mode, would be really insecure, so i added a define that help us to attach and detach them.