Skip to content

Fix JoinAttrs not handling nested Groups#293

Open
maragubot wants to merge 4 commits intomaragudk:mainfrom
maragubot:fix-joinattrs-nested-groups
Open

Fix JoinAttrs not handling nested Groups#293
maragubot wants to merge 4 commits intomaragudk:mainfrom
maragubot:fix-joinattrs-nested-groups

Conversation

@maragubot
Copy link
Copy Markdown
Contributor

Summary

  • JoinAttrs only flattened one level of g.Group, so attributes inside nested groups were rendered as duplicate attributes instead of being joined
  • Replaced the two-branch loop (one for groups, one for non-groups with duplicated logic) with a single recursive processNode closure that flattens groups to any depth

Test plan

  • Added test for joining classes across nested groups
  • Added test for preserving non-attribute nodes in nested groups
  • Added test for not joining attributes inside element children
  • Added test proving element-type nodes are never rendered during checking
  • All existing tests pass
  • Linter passes with zero issues

JoinAttrs only flattened one level of g.Group, so attributes inside
nested groups were rendered as duplicate attributes instead of being
joined. Replace the two-branch loop with a recursive closure that
flattens groups to any depth.
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (090d0fd) to head (4dbf825).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #293   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          639       635    -4     
=========================================
- Hits           639       635    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants