Fix JoinAttrs not handling nested Groups#293
Open
maragubot wants to merge 4 commits intomaragudk:mainfrom
Open
Fix JoinAttrs not handling nested Groups#293maragubot wants to merge 4 commits intomaragudk:mainfrom
maragubot wants to merge 4 commits intomaragudk:mainfrom
Conversation
JoinAttrs only flattened one level of g.Group, so attributes inside nested groups were rendered as duplicate attributes instead of being joined. Replace the two-branch loop with a recursive closure that flattens groups to any depth.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #293 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 639 635 -4
=========================================
- Hits 639 635 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JoinAttrsonly flattened one level ofg.Group, so attributes inside nested groups were rendered as duplicate attributes instead of being joinedprocessNodeclosure that flattens groups to any depthTest plan