from_zombie applied to spawned headcrab with expiration time instead of duration#501
Draft
1upD wants to merge 1 commit intomapbase-source:developfrom
Draft
from_zombie applied to spawned headcrab with expiration time instead of duration#5011upD wants to merge 1 commit intomapbase-source:developfrom
1upD wants to merge 1 commit intomapbase-source:developfrom
Conversation
…wned headcrab with expiration time instead of duration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…
While I was debugging an issue with Wilson's responses in Entropy : Zero 2, I came upon the realization that the "duration" parameter in
CBaseEntity::AddContext()is misnamed and actually represents an expiration time, not a duration.I found this example of a context being applied with a duration instead of an expiration time in Mapbase. It looks like it is a context applied to headcrabs to say that they spawned from zombies which only lasts for two seconds.
I have not properly tested this change in game as it was the result of testing an unrelated issue. Hence I will open this in draft status for now.
PR Checklist
developbranch OR targets another branch with a specific goal in mind