feat: Add Tooltip primitive#611
Conversation
|
@jordanarldt is attempting to deploy a commit to the Makeswift Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jordanarldt
force-pushed
the
ja/add-tooltip
branch
from
5fb2b12 to
b867991
Compare
| sideOffset?: number; | ||
| } | ||
|
|
||
| // eslint-disable-next-line valid-jsdoc |
There was a problem hiding this comment.
Should we remove this eslint-disable in VIBES?
There was a problem hiding this comment.
Ope yep! Good call
| className?: string; | ||
| delayDuration?: number; | ||
| skipDelayDuration?: number; | ||
| trigger?: React.ReactNode; |
There was a problem hiding this comment.
In what scenarios would we want a trigger being optional for tooltip?
There was a problem hiding this comment.
If it's being controlled externally by some other state or if the trigger needs to be detached from the component. For our use-case in catalyst it doesn't need to be optional, so I can make it required if needed!
But also, the trigger isn't required in the underlying Radix UI component IIRC!
2 participants
Add
Tooltipprimitive component