Autoload and templates#1
Open
makeartandgames wants to merge 17 commits into
Open
Conversation
In the editor, the Mono dialog button is missing the folder icon. This change adds it.
These two lines make the example crash, when it should work out of the box. It seems there's no path named like that, and seems to be a mistake to have it there.
Currently if one presses any folder button on the dock to the right, nothing happens. This is because the popup first emits `popup_hide` and then `file_selected`, causing the signal connection to break before `file_selected` is fired. To solve this I propose adding an enum that will change depending on the button is pressed. It'll be redundant to use 4 identical `EditorFileDialog`, we can still use one and change it's parameters. A new variable will hold the enum of the button pressed, and `file_selected` will execute `_on_file_selected` method that'll do a match on the selected enum and perform the correct action. If the FileDialog is canceled then `file_selected0` is not fired and the enum continues holding the past value. This value is overriden when a new button is pressed. If for some reason we end up with UNKNOWN that means this function was called from somewhere else other than the 4 buttons, which is not expected.
…up a document in Sphinx.This will be later used in ReadTheDocs: https://inkgd.readthedocs.io/ (ephread#42) * Inkgd docs: Add Sphinx initial files. These files are necessary to setup a document in Sphinx. This will be later used in ReadTheDocs: https://inkgd.readthedocs.io/ * Change master for main. There's no master branch in this repo.
* Inkgd docs: Add Sphinx initial files. These files are necessary to setup a document in Sphinx. This will be later used in ReadTheDocs: https://inkgd.readthedocs.io/ * Change master for main. There's no master branch in this repo. * Docs: First draft of getting started. * Fix * Address comments in ephread#46.
* Inkgd docs: Add Sphinx initial files. These files are necessary to setup a document in Sphinx. This will be later used in ReadTheDocs: https://inkgd.readthedocs.io/ * Change master for main. There's no master branch in this repo. * Docs: First draft of getting started. * Fix * Address comments in ephread#46. * Documentation: Add images to Getting Started. * Docs: Align flowchart to the center. * Docs: Center all images. * Add line separation between images.
* Push errors and warnings to editor in debug * Added template and autoload on plugin activation The plugin now will add the "Ink Template" template to the project the plugin is activated in. It will also create the "__InkRuntime" autoload. I have done some small tests, I would like to do some more but I haven't used GUT before, I need to familiarise myself with it first. * Added template directory Added a template directory in editor, so now you can add templates to that and they will be added to a project when the plugin is activated. Also added a .gdignore so it no longer shows up in the editor. I've also added a new template based on my personal implementation of using the yield function. I've also added the template_generator directory to the gitignore file so it won't show up. Note : I messed up while doing editing the templates and ended up editing the generated template, so I copied and pasted it into the plugin template, which is why it's saying I've rewritten the whole thing. * Delete script_templates directory Now it's added to .gitignore, remove it from the GitHub repository as it will be generated from the start. * Delete ink_template.gd Co-authored-by: Frédéric Maquin <fred@ephread.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.