[OPAL-529] invoices summary page - Tax not included in final Amount#329
Open
MAhsenArif wants to merge 2 commits intomaestrano:2.0from
Open
[OPAL-529] invoices summary page - Tax not included in final Amount#329MAhsenArif wants to merge 2 commits intomaestrano:2.0from
MAhsenArif wants to merge 2 commits intomaestrano:2.0from
Conversation
adamaziz15
approved these changes
Aug 22, 2018
| "mnoe_admin_panel.dashboard.invoice.expected_payment_date":"Expected payment date", | ||
| "mnoe_admin_panel.dashboard.invoice.amount":"Total amount", | ||
| "mnoe_admin_panel.dashboard.invoice.past_due": "Past Due", | ||
| "mnoe_admin_panel.dashboard.invoice.amount":"Total amount(excl. past due)", |
There was a problem hiding this comment.
Should there be a space between amount and (excl. past due)?
Contributor
|
Do NOT merge. Discussion pending. |
Contributor
Author
|
Not merging. Just some edge cases that I found out about and were not pushed |
Contributor
|
Yes, that was more for @adamaziz15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.