feat: posterior to Chi2 conversion#911
Merged
Merged
Conversation
|
Hi @KSkwarczynski, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this  Use this action on your projects. Use jokes on issues instead. |
|
Hi, I am MaCh3-Telemetry bot Memory and CPU Usage SummaryMemory Usage PlotYou can view the memory usage plot directly in the job summary from the link above. |
| } else { | ||
| GroupNameCurr = "Other"; // Use Other for all legacy params | ||
| } | ||
| if (IamVaried[iPar] == false) continue; |
Contributor
There was a problem hiding this comment.
Minor comment, can this be changed to ParamVaried
Contributor
There was a problem hiding this comment.
(this may not be in the scope of this PR)
Contributor
henry-wallace-phys
left a comment
henry-wallace-phys
left a comment
There was a problem hiding this comment.
Small fixes need to stop accidental divisions by 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request description
Posterior to Chi2 conversion is useful for comparing results with frequentist fitters.
Examples