Skip to content

tidy: cmake improvments#907

Open
KSkwarczynski wants to merge 1 commit into
developfrom
kskwarczynski/tidy/cmake
Open

tidy: cmake improvments#907
KSkwarczynski wants to merge 1 commit into
developfrom
kskwarczynski/tidy/cmake

Conversation

@KSkwarczynski
Copy link
Copy Markdown
Member

Pull request description

Several of cmake improvements

Changes or fixes

  • NuOsc version is not added to version.h
  • Libraries are added to MaCh3 all in individual cmake. If we reach a point where MaCh3 has more directories it will make easier to sustain it.
  • In find_package ROOT requires same version as in compilation, not any version larger than 6.20. This would not work most likely and cause difficult to debug problems.
  • Multiple directories had CUDA architecture even if they didn't compile any GPU code...

Examples

image

…obsolete cuda stuff and better handling of MaCh3::All
@KSkwarczynski KSkwarczynski self-assigned this May 15, 2026
@github-actions
Copy link
Copy Markdown

Hi @KSkwarczynski, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this

meme

Use this action on your projects. Use jokes on issues instead.

@github-actions github-actions Bot added Plotting 📊 plotting related MCMC 🎲 MCMC related Parameters ⚙️ Related with neutrino interactions or oscillations CI/CD 🤖 CI/CD Samples 🗃️ Manager 🧠 Cmake 🛠️ labels May 15, 2026
@github-actions
Copy link
Copy Markdown

Hi, I am MaCh3-Telemetry bot

Memory and CPU Usage Summary

### Memory and CPU Usage Summary

| Metric  |     Mean    |      Max    |
|---------|-------------|-------------|
| **RAM** |   357.58 MB |   359.69 MB |
| **CPU** |    96.66 %  |    98.50 %  |

Memory Usage Plot

You can view the memory usage plot directly in the job summary from the link above.

Comment thread CMakeLists.txt
cmake_minimum_required(VERSION 3.14 FATAL_ERROR)

project(MaCh3 VERSION 2.5.1 LANGUAGES CXX)
project(MaCh3 VERSION 2.6.0 LANGUAGES CXX)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this PR targeting 2.6.0?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just tagged 2.5.1 so might as well bump version to next one.
Dan, Luke and You hinted interest into features with breaking changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD 🤖 CI/CD Cmake 🛠️ Manager 🧠 MCMC 🎲 MCMC related Parameters ⚙️ Related with neutrino interactions or oscillations Plotting 📊 plotting related Samples 🗃️

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants