breaking: DRAFT -- ParameterHandlerBase refactor#721
Draft
luketpickering wants to merge 14 commits into
Draft
Conversation
luketpickering
requested review from
EdAtkin,
KSkwarczynski and
dbarrow257
as code owners
github-actions
Bot
added
MCMC 🎲
added 11 commits
December 18, 2025 17:05
- Adds ParameterList and StepProposer classes - Adds README that will contain design decisions - Removes PCAhandler as a separate class - Adds some local tests
…sses - Some particularly egregious interface points throw runtime errors. Can implement if we really really need to. - More test cases, including an RNG test of the step proposer and PCA rotation back and forth. - some const qualifying...
luketpickering
force-pushed
the
feature/ParameterHandlerBaseTidy
branch
from
aff689e to
62d5754
Compare
added 3 commits
December 19, 2025 10:45
- parameter list now just knows everything about the parameters - on proposal function creation, truncated PCA parameters can be passed - Using this abstraction seems more ergonomic as you don't need to keep going back to the parameter list to get the 'global' systematic parameter values - tests disabled for the moment as I'm in a bit of a rush to build mach3 dune
Contributor
Author
|
TODO:
|
luketpickering
changed the title
|
Stale pull request message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request description
Changes or fixes
Examples