Mutability Homework Submission

elm-todo/Todo.elm

@@ -45,7 +45,6 @@ type alias Model =
 type alias Entry =
     { description : String
     , completed : Bool
-    , editing : Bool
     , id : Int
     }
 
@@ -62,7 +61,6 @@ newEntry : String -> Int -> Entry
 newEntry desc id =
     { description = desc
     , completed = False
-    , editing = False
     , id = id
     }
 
@@ -76,8 +74,6 @@ to them.
 -}
 type Msg
     = UpdateNewEntryField String
-    | EditingEntry Int Bool
-    | UpdateEntry Int String
     | Add
     | Delete Int
     | DeleteAllCompleted
@@ -102,29 +98,6 @@ update msg model =
         UpdateNewEntryField str ->
             { model | newEntryField = str }
 
-        EditingEntry id isEditing ->
-            let
-                updateEntry t =
-                    if t.id == id then
-                        { t | editing = isEditing }
-                    else
-                        t
-
-                focus =
-                    Dom.focus ("todo-" ++ toString id)
-            in
-                { model | entries = List.map updateEntry model.entries }
-
-        UpdateEntry id task ->
-            let
-                updateEntry t =
-                    if t.id == id then
-                        { t | description = task }
-                    else
-                        t
-            in
-                { model | entries = List.map updateEntry model.entries }
-
         Check id isCompleted ->
             let
                 updateEntry t =
@@ -229,7 +202,7 @@ viewKeyedEntry todo =
 viewEntry : Entry -> Html Msg
 viewEntry todo =
     li
-        [ classList [ ( "completed", todo.completed ), ( "editing", todo.editing ) ] ]
+        [ classList [ ( "completed", todo.completed )] ]
         [ div
             [ class "view" ]
             [ input
@@ -240,24 +213,14 @@ viewEntry todo =
                 ]
                 []
             , label
-                [ onDoubleClick (EditingEntry todo.id True) ]
+                []
                 [ text todo.description ]
             , button
                 [ class "destroy"
                 , onClick (Delete todo.id)
                 ]
                 []
             ]
-        , input
-            [ class "edit"
-            , value todo.description
-            , name "title"
-            , id ("todo-" ++ toString todo.id)
-            , onInput (UpdateEntry todo.id)
-            , onBlur (EditingEntry todo.id False)
-            , onEnter (EditingEntry todo.id False)
-            ]
-            []
         ]
 
 
@@ -313,8 +276,7 @@ viewControlsClear entriesCompleted =
 infoFooter : Html msg
 infoFooter =
     footer [ class "info" ]
-        [ p [] [ text "Double-click to edit a todo" ]
-        , p []
+        [p []
             [ text "Written by "
             , a [ href "https://github.com/evancz" ] [ text "Evan Czaplicki" ]
             ]

ruby-todo/lib/engine.rb

@@ -4,9 +4,12 @@ def self.run(*args)
   end
 
   def self.run_with_history(model, messages)
+
+  	new_model = model
+
     messages.map do |msg|
-      msg.apply_to(model)
-      model
+      new_model = msg.apply_to(new_model)
+      new_model
     end
   end
 end

ruby-todo/lib/messages.rb

@@ -2,13 +2,21 @@ module Msg
 
   class Add
     def apply_to(model)
+
+      entries = model.entries.dup
+
       unless model.new_entry_field.blank?
-        model.entries << Entry.new(
+        entries << Entry.new(
           description: model.new_entry_field,
           id: model.next_id)
       end
-      model.next_id += 1
-      model.new_entry_field = ""
+
+      new_model = Model.new(
+        entries: entries,
+        new_entry_field: "",
+        next_id: model.next_id + 1)
+      new_model
+
     end
   end
 
@@ -20,7 +28,11 @@ def initialize(str)
     attr_reader :str 
 
     def apply_to(model)
-      model.new_entry_field = str
+      new_model = Model.new(
+        entries: model.entries,
+        new_entry_field: str,
+        next_id: model.next_id)
+      new_model
     end
   end
 
@@ -32,11 +44,27 @@ def initialize(id, is_completed)
     attr_reader :id, :is_completed 
 
     def apply_to(model)
-      model.entries.each do |entry|
+      entries = model.entries.dup
+
+      new_entries = []
+
+      entries.each do |entry|
         if entry.id == id
-          entry.completed = is_completed
+          new_entries.push(Entry.new(
+            id: entry.id,
+            description: entry.description, 
+            completed: is_completed))
+        else
+          new_entries.push(entry)
         end
       end
+
+      new_model = Model.new(
+        entries: new_entries,
+        new_entry_field: model.new_entry_field,
+        next_id: model.next_id)
+      new_model
+
     end
   end
 
@@ -48,13 +76,30 @@ def initialize(id)
     attr_reader :id 
 
     def apply_to(model)
-      model.entries.reject! { |e| e.id == id }
+      entries = model.entries.dup
+
+      entries.reject! { |e| e.id == id }
+
+      new_model = Model.new(
+        entries: entries,
+        new_entry_field: model.new_entry_field,
+        next_id: model.next_id)
+      new_model
     end
   end
 
   class DeleteAllCompleted
     def apply_to(model)
-      model.entries.reject!(&:completed)
+
+      entries = model.entries.dup
+
+      entries.reject!(&:completed)
+
+      new_model = Model.new(
+        entries: entries,
+        new_entry_field: model.new_entry_field,
+        next_id: model.next_id)
+      new_model
     end
   end
 

ruby-todo/lib/model.rb

@@ -5,7 +5,7 @@ def initialize(entries: [], new_entry_field: "", next_id: nil)
       (entries.lazy.map(&:id).max || -1) + 1
   end
 
-  attr_accessor :entries, :new_entry_field, :next_id
+  attr_reader :entries, :new_entry_field, :next_id
 
   def ==(other)
     !other.nil? &&
@@ -20,7 +20,7 @@ def initialize(id:, description:, completed: false)
     @description, @id, @completed = description, id, completed
   end
 
-  attr_accessor :description, :completed, :id
+  attr_reader :description, :completed, :id
 
   def ==(other)
     !other.nil? &&

ruby-todo/test/todo_test.rb

@@ -91,7 +91,7 @@
   end
 
   it "supports time travel" do
-    skip "Mutable model does not support time travel"
+    #skip "Mutable model does not support time travel"
 
     actual_history = Engine.run_with_history(Model.new, [
       Msg::UpdateNewEntryField.new("go forward in time"),

swift-todo/Sources/Todo/Engine.swift

@@ -13,9 +13,10 @@ struct Engine {
     }
 
     static func runWithHistory(on model: Model, applying messages: [Message]) -> [Model] {
+        var new_model: Model = model
         return messages.map { message in
-          message.apply(to: model)
-          return model
+          new_model = message.apply(to: new_model)
+          return new_model
         }
     }
 }

swift-todo/Sources/Todo/Message.swift

@@ -14,30 +14,41 @@ enum Message {
     case delete(Int)
     case deleteAllCompleted
 
-    func apply(to model: Model) {
+    func apply(to model: Model) -> Model {
+
+        var new_model: Model = model
+
         switch(self) {
+
             case .add:
-                if !model.newEntryField.isBlank() {
-                    model.entries.append(Entry(id: model.nextID, description: model.newEntryField))
+                if !new_model.newEntryField.isBlank() {
+                    new_model.entries.append(Entry(id: model.nextID, description: model.newEntryField))
                 }
-                model.nextID += 1
-                model.newEntryField = ""
+                new_model.nextID += 1
+                new_model.newEntryField = ""
 
             case .updateNewEntryField(let str):
-                model.newEntryField = str
+                new_model.newEntryField = str
 
             case .check(let id, let isCompleted):
-                for entry in model.entries {
+                var new_entries: [Entry] = []
+
+                for entry in new_model.entries {
                     if(entry.id == id) {
-                        entry.completed = isCompleted
+                        new_entries.append(Entry(id: entry.id, description: entry.description, completed: isCompleted))
+                    } else {
+                        new_entries.append(entry)
                     }
                 }
+
+                new_model.entries = new_entries
 
             case .delete(let id):
-                model.entries.remove { $0.id == id }
+                new_model.entries.remove { $0.id == id }
 
             case .deleteAllCompleted:
-                model.entries.remove { $0.completed }
+                new_model.entries.remove { $0.completed }
         }
+        return new_model
     }
 }

swift-todo/Sources/Todo/Model.swift

@@ -1,4 +1,4 @@
-class Model {
+struct Model {
     var entries: [Entry]
     var newEntryField: String
     var nextID: Int
@@ -11,7 +11,7 @@ class Model {
     }
 }
 
-class Entry {
+struct Entry {
     var id: Int
     var description: String
     var completed: Bool

swift-todo/Tests/TodoTests/TodoTests.swift

@@ -77,7 +77,7 @@ class TodoTests: XCTestCase {
          XCTAssertEqual([11], newModel.entries.map { $0.id })
      }
 
-/*
+
      func testTimeTravel() {
         let actualHistory = Engine.runWithHistory(on: Model(), applying: [
              .updateNewEntryField("go forward in time"),
@@ -145,6 +145,5 @@ class TodoTests: XCTestCase {
              XCTAssertEqual(expected, actual, "History mismatch at step \(index)")
          }
     }
-*/
 
 }