Add config overriding and loading of external plugins#313
Open
Add config overriding and loading of external plugins#313
Conversation
9b4ba46 to
227d206
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, it is very annoying to update trakman especially with Docker containers (also the Update.js script is broken on dev), because the user needs to manually go in and review the changes that have been made. With this approach, we could instead ship the container with a statically compiled version of Trakman, and the user can configure the controller through adding config overrides, as example:
export default { title: 'test2' }inside overrides/plugins/ui/static_components/race/LiveRanking.config.js, which will have priority over the Trakman "default" config.
I already ship my servers with a static version of trakman, but this way i could come closer to upstream again, and i have helped a person to deploy a trakman server using docker, through which i noticed that the current process is not ideal.
This pr also adds the functionality to add extra plugins, which i can load through overriding the Config.js file as example with the following content:
export default { externalPlugins: [ '../custom_plugins/emojis/Emojis.ts' ] }This would load my custom emojis plugin, which resides in a different folder. For users that run it bare metal, they could still change the files as they did before, or they might adapt to using it aswell.
It is not ideal yet, i would love to get some feedback on it.