log that job logs are persisted in cleanup instead of normal close path#784
Merged
log that job logs are persisted in cleanup instead of normal close path#784
Conversation
Contributor
Author
|
/ptal @lyft/deploys |
EzeGGonzalez
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's possible for a worker to get killed before a job can persist logs from in-memory to storage backend. When a new worker picks up the pending CloseJob activity, the cleanup path will retry the job Close routine but the logs that were only in-memory before the previous worker shutdown would be lost.
On user side this would look like an empty temporal log despite an alantis plan/validate/apply process completing.
We can't recover the lost logs but this warning just tells us that this is what happened.