Conversation
|
@scoder This is probably not quite ready yet considering the library dependency is not yet available in the libxml2-win-binaries repository. But would be nice to hear your thoughts on how to resolve the dependency etc. to get this sorted for win/arm64 targets. |
|
It doesn't hurt to merge it already. Regarding Windows library building, I actually don't know how they were previously built. Having a build script for Github Actions would certainly be very much appreciated. |
|
Thanks, @scoder. As the external dependencies for windows were pulled from libxml2-win-binaries, I've created a PR to extend the appveyor build scripts and related files in libxml2-win-binaries to add win-arm64 packages. Unfortunately, the maintainer of libxml2-win-binaries doesn't have time to maintain the repository and he left a comment for you to look for an owner for that repository. Could you suggest what would be the best way to resolve this issue? I've also created a full library release through appveyor here which includes packages for all supported platforms including win-arm64. |
| if sys.version_info < (3, 5): | ||
| arch = 'vs2008.' + arch | ||
| elif platform.machine() == 'ARM64': | ||
| arch = "win-arm64" | ||
| elif sys.maxsize > 2**32: | ||
| arch = "win64" | ||
| else: | ||
| arch = "win32" |
There was a problem hiding this comment.
This diff breaks the arch reference in the first if-block and breaks the py27 builds on appveyor:
- https://ci.appveyor.com/project/scoder/lxml/builds/41249423/job/vnu6gmaa3u0f4by7#L49
- https://ci.appveyor.com/project/scoder/lxml/builds/41249423/job/173d08dq3bbx6mef#L57
Not sure how relevant this is considering you're currently trying to sort out the dependency builds in the remote repository, but just wanted to let you know in case you haven't noticed already.
There was a problem hiding this comment.
Yes I think the statements in lines 41 and 42 should be moved after line 48
There was a problem hiding this comment.
Thanks, yeah, I noticed this, too, when I was trying to set up an automated wheel build.
There was a problem hiding this comment.
(Sorry for breaking your original PR)
This patch enables building lxml package for win/arm64 platforms.
The change expects win/arm64 libraries to be available in repository currently used for getting x86 and x64 dependencies. The packages are not yet available in the repository but a PR has been raised to add arm64 libraries.
Unofficial release of win/arm64 libraries from PR are available here
Test Result