Skip to content

docs: add project.mdx, and databinding updates#361

Open
kisvegabor wants to merge 5 commits into
masterfrom
feat/more-details
Open

docs: add project.mdx, and databinding updates#361
kisvegabor wants to merge 5 commits into
masterfrom
feat/more-details

Conversation

@kisvegabor
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 4 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="docs/syntax/data-binding.mdx">

<violation number="1" location="docs/syntax/data-binding.mdx:109">
P2: Use the complex state binding child-element form with `subject="..."`; this attribute-style snippet is inconsistent with the rest of the docs and likely invalid.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread docs/syntax/data-binding.mdx Outdated
Comment thread docs/syntax/data-binding.mdx Outdated
Comment thread docs/syntax/data-binding.mdx Outdated
Comment thread docs/syntax/data-binding.mdx Outdated
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="docs/syntax/data-binding.mdx">

<violation number="1" location="docs/syntax/data-binding.mdx:107">
P2: The binding tag is not closed, making this XML example invalid.</violation>

<violation number="2" location="docs/syntax/data-binding.mdx:112">
P2: This binding tag is also left unclosed, so the sample XML is invalid.</violation>
</file>

Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic


<!-- Enter the "checked" state while subject_lamp == 2 -->
<lv_obj>
<bind_state_if_eq subject="subject_lamp" state="checked" ref_value="2">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: This binding tag is also left unclosed, so the sample XML is invalid.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At docs/syntax/data-binding.mdx, line 112:

<comment>This binding tag is also left unclosed, so the sample XML is invalid.</comment>

<file context>
@@ -103,10 +103,14 @@ write `bind_state_if_gt` instead.
 <!-- Enter the "checked" state while subject_lamp == 2 -->
-<lv_button bind_state_if_eq="subject_lamp" state="checked" ref_value="2"/>
+<lv_obj>
+  <bind_state_if_eq subject="subject_lamp" state="checked" ref_value="2">
+</lv_obj>

</file context>


</details>

```suggestion
  <bind_state_if_eq subject="subject_lamp" state="checked" ref_value="2"/>

Tip: Review your code locally with the cubic CLI to iterate faster.

```xml
<!-- Set the "hidden" flag while subject_mode != 1 -->
<lv_obj>
<bind_flag_if_not_eq subject="subject_mode" flag="hidden" ref_value="1">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: The binding tag is not closed, making this XML example invalid.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At docs/syntax/data-binding.mdx, line 107:

<comment>The binding tag is not closed, making this XML example invalid.</comment>

<file context>
@@ -103,10 +103,14 @@ write `bind_state_if_gt` instead.
 <!-- Set the "hidden" flag while subject_mode != 1 -->
-<lv_obj bind_flag_if_not_eq="subject_mode" flag="hidden" ref_value="1"/>
+<lv_obj>
+  <bind_flag_if_not_eq subject="subject_mode" flag="hidden" ref_value="1">
+</lv_obj>
 
</file context>
Suggested change
<bind_flag_if_not_eq subject="subject_mode" flag="hidden" ref_value="1">
<bind_flag_if_not_eq subject="subject_mode" flag="hidden" ref_value="1"/>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant