Defensively normalize translated text synthesis in admin#2446
Open
tazzytazzy wants to merge 3 commits intolunarphp:1.xfrom
Open
Defensively normalize translated text synthesis in admin#2446tazzytazzy wants to merge 3 commits intolunarphp:1.xfrom
tazzytazzy wants to merge 3 commits intolunarphp:1.xfrom
Conversation
alecritson
reviewed
Apr 14, 2026
| public function get(&$target, $key) | ||
| { | ||
| return $target->{$key}; | ||
| // return $target->{$key}; |
Collaborator
There was a problem hiding this comment.
Can we just remove commented out code :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
TranslatedTextSynth was still using fragile behavior when Lunar\FieldTypes\TranslatedText crossed a Livewire boundary directly.
In the old behavior:
This was not the root fix for the main product rich-text issue #2445 , but it left the synthesizer inconsistent and brittle.
What Changed
Result
The translated text synthesizer now behaves safely and consistently if a TranslatedText field is hydrated, accessed, or mutated directly through Livewire.
This is a defensive correctness patch and is intentionally separate from the main AttributeData fix.
Code Generation Source
Codex 5.4 on Extra reasoning settings. I have also personally tested the results within the Lunar admin panel, and the patch is working as expected. This PR was split up from #2445 for separation of concerns/attribution.