Skip to content

Change Cart type hint to CartContract in getDiscounts #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
YannikFirre wants to merge 1 commit into from
Closed

Change Cart type hint to CartContract in getDiscounts #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Managers/DiscountManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
use Lunar\Base\Validation\CouponValidator;
use Lunar\DiscountTypes\AmountOff;
use Lunar\DiscountTypes\BuyXGetY;
use Lunar\Models\Cart;
use Lunar\Models\Channel;
use Lunar\Models\Contracts\Cart as CartContract;
use Lunar\Models\Contracts\Channel as ChannelContract;
Expand Down Expand Up @@ -119,7 +118,7 @@ public function getChannels(): Collection
/**
* Returns the available discounts.
*/
public function getDiscounts(?Cart $cart = null): Collection
public function getDiscounts(?CartContract $cart = null): Collection
{
if ($this->channels->isEmpty() && $defaultChannel = Channel::getDefault()) {
$this->channel($defaultChannel);
Expand Down
Loading